Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Github OAuth provider configuration #16712

Closed
wants to merge 1 commit into from
Closed

Fix Github OAuth provider configuration #16712

wants to merge 1 commit into from

Conversation

zeripath
Copy link
Contributor

There was a regression in #16544 whereby the default token url
for github was changed to the gitea one.

This PR restores this.

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Fix Github oauth provider configuration
1de92b1 
There was a regression in go-gitea#16544 whereby the default token url
for github was changed to the gitea one.

This PR restores this.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 17, 2021
@zeripath zeripath added this to the 1.16.0 milestone Aug 17, 2021
@zeripath zeripath changed the title Fix Github oauth provider configuration Fix Github OAuth provider configuration Aug 17, 2021
@zeripath zeripath added the issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change label Aug 17, 2021
@KN4CK3R
Copy link
Member

KN4CK3R commented Aug 17, 2021

Duplicate of #16709

@KN4CK3R KN4CK3R marked this as a duplicate of #16709 Aug 17, 2021
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 17, 2021
@zeripath zeripath closed this Aug 17, 2021
@zeripath zeripath deleted the fix-github-oauth-provider branch August 17, 2021 08:06
@zeripath
Copy link
Contributor Author

Opened by mistake Duplicate

@zeripath
Copy link
Contributor Author

Replaced by #16709

@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@zeripath @KN4CK3R @GiteaBot